netdev - Re: [PATCH net-next v2 1/2] if_link: add client name to port profile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141004200523.4fc102e3@urahara>
Date:	Sat, 4 Oct 2014 20:05:23 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Govindarajulu Varadarajan <_govind@....com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, ssujith@...co.com,
	benve@...co.com
Subject: Re: [PATCH net-next v2 1/2] if_link: add client name to port
 profile

On Fri,  3 Oct 2014 04:11:22 +0530
Govindarajulu Varadarajan <_govind@....com> wrote:

> This patch adds client name to port profile.
> 
> This is used by netlink client to send the client name in port profile.
> 
> Signed-off-by: Govindarajulu Varadarajan <_govind@....com>
> ---
>  include/uapi/linux/if_link.h | 1 +
>  net/core/rtnetlink.c         | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
> index 0bdb77e..6ae0b0b 100644
> --- a/include/uapi/linux/if_link.h
> +++ b/include/uapi/linux/if_link.h
> @@ -512,6 +512,7 @@ enum {
>  	IFLA_PORT_HOST_UUID,		/* binary UUID */
>  	IFLA_PORT_REQUEST,		/* __u8 */
>  	IFLA_PORT_RESPONSE,		/* __u16, output only */
> +	IFLA_PORT_VMNAME,		/* vm-name used by port profile */
>  	__IFLA_PORT_MAX,
>  };
>  
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index a688268..116d647 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -1238,6 +1238,8 @@ static const struct nla_policy ifla_port_policy[IFLA_PORT_MAX+1] = {
>  				    .len = PORT_UUID_MAX },
>  	[IFLA_PORT_REQUEST]	= { .type = NLA_U8, },
>  	[IFLA_PORT_RESPONSE]	= { .type = NLA_U16, },
> +	[IFLA_PORT_VMNAME]	= { .type = NLA_STRING,
> +				    .len = PORT_PROFILE_MAX },
>  };
>  
>  static int rtnl_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb)

Maybe you could use the existing IFLA_IFALIAS?
It is already supported by iproute tools and sysfs, and can be used by net-snmp as well.
You would just be setting the default string, users could change it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html