netdev - Re: [PATCH ethtool 2/3] ethtool: Add rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5430F923.9050005@mellanox.com>
Date:	Sun, 5 Oct 2014 10:54:11 +0300
From:	Amir Vadai <amirv@...lanox.com>
To:	Govindarajulu Varadarajan <_govind@....com>, <ben@...adent.org.uk>
CC:	<netdev@...r.kernel.org>, <ssujith@...co.com>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	"Eric Dumazet" <eric.dumazet@...il.com>
Subject: Re: [PATCH ethtool 2/3] ethtool: Add rx_copybreak support

On 9/13/2014 12:56 PM, Govindarajulu Varadarajan wrote:
> Signed-off-by: Govindarajulu Varadarajan <_govind@....com>
> ---

[...]

>  	  "		[ rx-jumbo N ]\n"
>  	  "		[ tx N ]\n" },
> +	{ "-b|--show-rx_copybreak", 1, do_grx_copybreak, "Show rx_copybreak value" },
> +	{ "-B|--set-rx_copybreak", 1, do_srx_copybreak, "Set rx_copybreak value",
> +	  "		N\n" },
>  	{ "-k|--show-features|--show-offload", 1, do_gfeatures,

Hi,

Since a get/set for TX copybreak will be also is needed, please change
the user command to something like "-b rx NNN", and when I will add tx
copybreak support, I will add "-b tx NNN".

Thanks,
amir

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html