netdev - RE: [PATCH v2 net-next 15/15] tipc: remove old ASCII netlink API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Oct 2014 13:37:14 +0000
From:	Jon Maloy <jon.maloy@...csson.com>
To:	David Miller <davem@...emloft.net>,
	Richard Alpe <richard.alpe@...csson.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"tipc-discussion@...ts.sourceforge.net" 
	<tipc-discussion@...ts.sourceforge.net>
Subject: RE: [PATCH v2 net-next 15/15] tipc: remove old ASCII netlink API



> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-
> owner@...r.kernel.org] On Behalf Of David Miller
> Sent: October-03-14 7:51 PM
> To: Richard Alpe
> Cc: netdev@...r.kernel.org; tipc-discussion@...ts.sourceforge.net
> Subject: Re: [PATCH v2 net-next 15/15] tipc: remove old ASCII netlink API
> 
> From: <richard.alpe@...csson.com>
> Date: Thu, 2 Oct 2014 16:58:41 +0200
> 
> > From: Richard Alpe <richard.alpe@...csson.com>
> >
> > The API has been deprecated along with its user-space tool
> > "tipc-config". Users shall use the new kernel netlink API already in
> > place along with the new user space tool "tipc" that's part of the
> > tipc-utils package.
> >
> > Signed-off-by: Richard Alpe <richard.alpe@...csson.com>
> > Reviewed-by: Erik Hugne <erik.hugne@...csson.com>
> > Reviewed-by: Jon Maloy <jon.maloy@...csson.com>
> > Acked-by: Ying Xue <ying.xue@...driver.com>
> 
> Sorry, no matter what your circumstances, you cannot just break binaries
> that might be out there.

I disagree.  We did of course consider this before we posted the patch.  
There is absolutely no reason to believe there are binaries "out there" 
using this API. It is intended for and used only by our own tool "tipc-config", 
and the half-baked documentation that exists about it is not even
correct. This is an TIPC-internal API/ABI, which has changed over the years,
and keeps changing.  To our best judgement there is no risk in removing the
old API.

However, we took great care to not break any scripts that might be using 
tipc-config. Therefore, we made this wrapper that provides the old 
tipc-config command API to existing users.

Regards
///jon
> 
> The rest of this patch series is fine, but I'm really not going to even entertain
> applying this one, sorry.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in the body
> of a message to majordomo@...r.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html