lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 6 Oct 2014 22:01:08 +0300 (EEST) From: Julian Anastasov <ja@....bg> To: Alex Gartrell <agartrell@...com> cc: horms@...ge.net.au, dan.carpenter@...cle.com, lvs-devel@...r.kernel.org, netdev@...r.kernel.org, kernel-team@...com Subject: Re: [PATCH net-next] ipvs: Avoid null-pointer deref in debug code Hello, On Mon, 6 Oct 2014, Alex Gartrell wrote: > Use daddr instead of reaching into dest. > > Reported-by: Dan Carpenter <dan.carpenter@...cle.com> > Signed-off-by: Alex Gartrell <agartrell@...com> Thanks! Acked-by: Julian Anastasov <ja@....bg> > --- > net/netfilter/ipvs/ip_vs_xmit.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/netfilter/ipvs/ip_vs_xmit.c b/net/netfilter/ipvs/ip_vs_xmit.c > index 91f17c1..437a366 100644 > --- a/net/netfilter/ipvs/ip_vs_xmit.c > +++ b/net/netfilter/ipvs/ip_vs_xmit.c > @@ -316,7 +316,7 @@ __ip_vs_get_out_rt(int skb_af, struct sk_buff *skb, struct ip_vs_dest *dest, > if (unlikely(crosses_local_route_boundary(skb_af, skb, rt_mode, > local))) { > IP_VS_DBG_RL("We are crossing local and non-local addresses" > - " daddr=%pI4\n", &dest->addr.ip); > + " daddr=%pI4\n", &daddr); > goto err_put; > } > > @@ -458,7 +458,7 @@ __ip_vs_get_out_rt_v6(int skb_af, struct sk_buff *skb, struct ip_vs_dest *dest, > if (unlikely(crosses_local_route_boundary(skb_af, skb, rt_mode, > local))) { > IP_VS_DBG_RL("We are crossing local and non-local addresses" > - " daddr=%pI6\n", &dest->addr.in6); > + " daddr=%pI6\n", daddr); > goto err_put; > } > > -- > Alex Gartrell <agartrell@...com> Regards -- Julian Anastasov <ja@....bg> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists