netdev - Re: [PATCH net-next] net: bcmgenet: improve bcmgenet_mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141006.001840.1053267802558927782.davem@davemloft.net>
Date:	Mon, 06 Oct 2014 00:18:40 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	pgynther@...gle.com
Cc:	netdev@...r.kernel.org, f.fainelli@...il.com
Subject: Re: [PATCH net-next] net: bcmgenet: improve bcmgenet_mii_setup()

From: Petri Gynther <pgynther@...gle.com>
Date: Fri,  3 Oct 2014 12:25:01 -0700 (PDT)

> bcmgenet_mii_setup() is called from the PHY state machine every 1-2 seconds
> when the PHYs are in PHY_POLL mode.
> 
> Improve bcmgenet_mii_setup() so that it touches the MAC registers only when
> the link is up and there was a change to link, speed, duplex, or pause status.
> 
> Signed-off-by: Petri Gynther <pgynther@...gle.com>

Yeah that's ugly reprogramming so much stuff unnecessarily every
second or two, applied thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html