netdev - Re: [PATCH net-next] net: sched: avoid costly atomic operation in fq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141006.005529.1177842595653176576.davem@davemloft.net>
Date:	Mon, 06 Oct 2014 00:55:29 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: sched: avoid costly atomic operation in
 fq_dequeue()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 04 Oct 2014 10:11:31 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Standard qdisc API to setup a timer implies an atomic operation on every
> packet dequeue : qdisc_unthrottled()
> 
> It turns out this is not really needed for FQ, as FQ has no concept of
> global qdisc throttling, being a qdisc handling many different flows,
> some of them can be throttled, while others are not.
> 
> Fix is straightforward : add a 'bool throttle' to
> qdisc_watchdog_schedule_ns(), and remove calls to qdisc_unthrottled()
> in sch_fq.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html