netdev - Re: [PATCH net] bna: page allocation during interrupts to use a mempool.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1410061956410.7392@ware.dreamhost.com>
Date:	Mon, 6 Oct 2014 20:05:39 -0700 (PDT)
From:	Eric Wheeler <netdev@...ts.ewheeler.net>
To:	Eric Dumazet <eric.dumazet@...il.com>
cc:	Shahed Shaikh <shahed.shaikh@...gic.com>,
	Stephen Hemminger <stephen@...workplumber.org>,
	netdev <netdev@...r.kernel.org>,
	Rasesh Mody <rasesh.mody@...gic.com>
Subject: Re: [PATCH net] bna: page allocation during interrupts to use a
 mempool.

On Mon, 6 Oct 2014, Eric Dumazet wrote:
> On Mon, 2014-10-06 at 18:57 -0700, Eric Wheeler wrote:
>> This patch fixes an order:2 memory allocation error backtrace by
>> guaranteeing that memory is available during simultaneous high memory
>> pressure and packet rates when using 9k jumbo frames.
>
> This is highly suspect to me.
> Most likely yet another truesize lie.
> At a first glance, bnad_cq_setup_skb_frags() is buggy here :
> skb->truesize += totlen;

skb->truesize wasn't part of my patch, can you explain in more detail what 
you suggest a better fix might be? If you write a quick patch I can test 
it.

The patch in question implements a simple mempool for the interrupt page 
allocs---which definitely fixes the problem even if a better solution 
might exist.  I have no problem giving up a small amount of memory to 
guarantee page allocs in the interrupt handler.

It would be great to see this patch pushed through since it does fix the 
problem---at least until we can come up with a better fix.  I'm happy to 
test if you can send a patch.

-Eric

>
> With this kind of lies, system can OOM very fast.
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html