netdev - Re: [PATCH net-next] icmp6: Add new icmpv6 type for RPL control message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1412713590.11600.5.camel@localhost>
Date:	Tue, 07 Oct 2014 22:26:30 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	David Miller <davem@...emloft.net>
Cc:	simon.vincent@...lon.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] icmp6: Add new icmpv6 type for RPL control
 message

On Di, 2014-10-07 at 15:55 -0400, David Miller wrote:
> From: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Date: Tue, 07 Oct 2014 01:53:46 +0200
> 
> > Might be possible, but I would favor to get rid of the printk or move
> > the test for informational icmp notifications up.
> > Some of the type < 128 icmp (non-informal) packets we also report to
> > user space, so we cannot just add them to a blacklist.
> 
> So basically:
> 
> diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c
> index 141e1f3..97ae700 100644
> --- a/net/ipv6/icmp.c
> +++ b/net/ipv6/icmp.c
> @@ -777,12 +777,12 @@ static int icmpv6_rcv(struct sk_buff *skb)
>  		break;
>  
>  	default:
> -		LIMIT_NETDEBUG(KERN_DEBUG "icmpv6: msg of unknown type\n");
> -
>  		/* informational */
>  		if (type & ICMPV6_INFOMSG_MASK)
>  			break;
>  
> +		LIMIT_NETDEBUG(KERN_DEBUG "icmpv6: msg of unknown type\n");
> +
>  		/*
>  		 * error of unknown type.
>  		 * must pass to upper level

Yep, can you take care of this?

Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Thanks! :)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html