lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 08 Oct 2014 15:45:13 -0400 (EDT) From: David Miller <davem@...emloft.net> To: hayeswang@...ltek.com Cc: netdev@...r.kernel.org, nic_swsd@...ltek.com, linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org Subject: Re: [PATCH net-next] r8152: use mutex for hw settings From: Hayes Wang <hayeswang@...ltek.com> Date: Tue, 7 Oct 2014 13:36:30 +0800 > Use mutex to avoid that the serial hw settings would be interrupted > by other settings. Although there is no problem now, it makes the > driver more safe. > > Signed-off-by: Hayes Wang <hayeswang@...ltek.com> I think a much simpler fix is to take rtnl_lock() in the workqueue function and suspend/resume ops. Every other place you are adding the mutex already holds the RTNL mutex. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists