netdev - Re: [PATCH] igb: Indicate failure on vf reset for empty mac address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <543672DE.80202@cogentembedded.com>
Date:	Thu, 09 Oct 2014 15:34:54 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Alexander Graf <agraf@...e.de>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
CC:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Mitch Williams <mitch.a.williams@...el.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	Stefan Assmann <sassmann@...nic.de>,
	Aaron Brown <aaron.f.brown@...el.com>,
	Greg Rose <gregory.v.rose@...el.com>,
	John Ronciak <john.ronciak@...el.com>
Subject: Re: [PATCH] igb: Indicate failure on vf reset for empty mac address

Hello.

On 10/9/2014 1:23 AM, Alexander Graf wrote:

> Commit 5ac6f91d changed the igb driver to expose a zero (empty) mac

   Please also specify that commit's summary line in parens.

> address to the VF on reset rather than a random one.

> However, that behavioral change also requires igbvf driver changes
> which can be hard especially when we want to talk to proprietary
> guest OSs.

> Looking at the code previous to the commit in Linux that made igbvf
> work with empty mac addresses (8d56b6d), we can see that on reset

    And that one's

> failure the driver will try to generate a new mac address with both
> the old and the new code.

> Furthermore, ixgbe does send reset failure when it detects an empty
> mac address (35055928c).

    And that one's too.

> So I think it's safe to make igb behave the same. With this patch I
> can successfully run a Windows 8.1 guest with an empty mac address
> and an assigned igbvf device that has no mac address set by the host.

> If anyone is aware of a guest driver that chokes on NACK returns of
> VF RESET commands, please speak up.

> Signed-off-by: Alexander Graf <agraf@...e.de>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html