| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 09 Oct 2014 18:45:58 -0400 (EDT) From: David Miller <davem@...emloft.net> To: boger@...tactless.ru Cc: dforsi@...il.com, steve.glendinning@...well.net, netdev@...r.kernel.org, linux-usb@...r.kernel.org Subject: Re: [PATCH v3] Add support for GPIOs for SMSC LAN95xx chips. From: Evgeny Boger <boger@...tactless.ru> Date: Thu, 9 Oct 2014 02:14:58 +0400 > There might be 11 GPIOs in total. > Last three GPIOs (offsets 8-10, 0-based) are shared with FDX, LNKA, SPD > LEDs respectively. The LEDs are driven by chip by default at startup time. > Once the corresponding GPIO is requested, the chip LED drive logic is disabled. > > The numbering scheme according to datasheets differs a bit between LAN9500 > and LAN951x. > > For LAN951x: > GPIOs with offsets 0-7 are named "GPIO3" - "GPIO7", > offsets 8-10 are for "GPIO0" - "GPIO2" (these three are multiplexed with nFDX_LED, > nLNKA_LED, nSPD_LED). > > For LAN9500: > The datasheet name is the same as the corresponding offset, i.e. offsets 0-10 are > for "GPIO0"-"GPIO10". > > Signed-off-by: Evgeny Boger <boger@...tactless.ru> Please either "select GPIOLIB" from USB_NET_SMSC95XX, or add a new config option "UBS_NET_SMSC95XX_GPIO" which does it. I would prefer the former, and then you can get rid of all of the ifdefs in your patch. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists