netdev - Re: [bisected] e341694e3eb5 netlink_lookup() rcu conversion causes latencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141011.190829.876705206204533685.davem@davemloft.net>
Date:	Sat, 11 Oct 2014 19:08:29 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...g.ch
Cc:	eric.dumazet@...il.com, heiko.carstens@...ibm.com,
	sasha.levin@...cle.com, paulmck@...ux.vnet.ibm.com,
	nikolay@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, braunu@...ibm.com
Subject: Re: [bisected] e341694e3eb5 netlink_lookup() rcu conversion causes
 latencies

From: Thomas Graf <tgraf@...g.ch>
Date: Sat, 11 Oct 2014 23:25:14 +0100

> I think the issue here is obvious and a fix is on the way to move
> the insertion and removal to a worker to no longer require the
> synchronize_rcu().
> 
> What bothers me is that the synchronize_rcu() should only occur
> on expand/shrink and not for every table update. The default table
> size is 64.

Not true, every netlink socket release incurs a synchronize_net()
now, because we added such a call to netlink_release().

I specifically brought this up to as a possible problem when the
changes went in...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html