netdev - Re: Fw: [Bug 86081] New: Can't free the return value of sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHA+R7OgvPOM1GVQOU5eJreM2R5V-SxkO4nubVYoLdCvS_hUAQ@mail.gmail.com>
Date:	Mon, 13 Oct 2014 13:58:56 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	Andy Grover <andy.grover@...cle.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: Fw: [Bug 86081] New: Can't free the return value of
 sock_kmalloc() when the value is NULL

On Sun, Oct 12, 2014 at 8:07 AM, Stephen Hemminger
<stephen@...workplumber.org> wrote:
>
> in function rds_cmsg_rdma_args() at net/rds/rdma.c:L546, the variable
> "iovstack" is an array and the pointer variable *iovs is equal to iovstack (at
> Line 554). As the the return value of sock_kmalloc() (called at line 578),when
> "iovs" is NULL, function sock_kfree_s() will be called(at line 697) and
> function sock_kfree_s() will free "iovs".
> The related code snippets in function rds_cmsg_rdma_args() are as followings.
> rds_cmsg_rdma_args() at net/rds/rdma.c:L546

Free'ing NULL is okay, but not sub'ing the sk_omem_alloc size.
I will send a patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html