netdev - Re: [PATCH net-next] tg3: Add skb->xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Oct 2014 10:14:17 -0700
From:	Rick Jones <rick.jones2@...com>
To:	Eric Dumazet <eric.dumazet@...il.com>,
	Prashant Sreedharan <prashant@...adcom.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org, dborkman@...hat.com,
	mchan@...adcom.com
Subject: Re: [PATCH net-next] tg3: Add skb->xmit_more support

On 10/13/2014 09:48 AM, Eric Dumazet wrote:
> On Mon, 2014-10-13 at 09:21 -0700, Prashant Sreedharan wrote:
>> Ring TX doorbell only if xmit_more is not set or the queue is stopped.
>>
>> Suggested-by: Daniel Borkmann <dborkman@...hat.com>
>> Signed-off-by: Prashant Sreedharan <prashant@...adcom.com>
>> Signed-off-by: Michael Chan <mchan@...adcom.com>
>> ---
>>   drivers/net/ethernet/broadcom/tg3.c |   10 ++++++----
>>   1 files changed, 6 insertions(+), 4 deletions(-)
>
> Have you noticed any performance change ?
>
> I did the patch for bnx2x but got no real difference...

If ringing the doorbell is just a pio write, it may just get lost in the 
noise.  If though the programming model (or some sort of defect 
workaround) of the NIC requires a pio read of some sort when ringing the 
doorbell...

rick
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html