netdev - Re: [PATCH stable v3.2 v3.4] ipv4: disable bh while doing route gc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141013.135127.1915115817707962111.davem@davemloft.net>
Date:	Mon, 13 Oct 2014 13:51:27 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mleitner@...hat.com
Cc:	stable@...r.kernel.org, netdev@...r.kernel.org,
	hannes@...essinduktion.org
Subject: Re: [PATCH stable v3.2 v3.4] ipv4: disable bh while doing route gc

From: Marcelo Ricardo Leitner <mleitner@...hat.com>
Date: Mon, 13 Oct 2014 14:03:30 -0300

> Further tests revealed that after moving the garbage collector to a work
> queue and protecting it with a spinlock may leave the system prone to
> soft lockups if bottom half gets very busy.
> 
> It was reproced with a set of firewall rules that REJECTed packets. If
> the NIC bottom half handler ends up running on the same CPU that is
> running the garbage collector on a very large cache, the garbage
> collector will not be able to do its job due to the amount of work
> needed for handling the REJECTs and also won't reschedule.
> 
> The fix is to disable bottom half during the garbage collecting, as it
> already was in the first place (most calls to it came from softirqs).
> 
> Signed-off-by: Marcelo Ricardo Leitner <mleitner@...hat.com>
> Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Acked-by: David S. Miller <davem@...emloft.net>
> Cc: stable@...r.kernel.org

-stable folks, please integrate this directly, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html