[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20141014.164117.553206792335727136.davem@davemloft.net>
Date: Tue, 14 Oct 2014 16:41:17 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: peppe.cavallaro@...com
Cc: netdev@...r.kernel.org, maxime.coquelin@...com
Subject: Re: [PATCH (net.git) 0/2] stmmac: review and fix the dwmac-sti
glue-logic
From: Giuseppe Cavallaro <peppe.cavallaro@...com>
Date: Tue, 14 Oct 2014 08:12:54 +0200
> This patch is to review the whole glue logic adopted on STi SoCs that
> was bugged.
> In the old glue-logic there was a lot of confusion when setup the
> retiming especially for STiD127 where, for example, the bits 6 and 7
> (in the GMAC control register) have a different meaning of what is
> used for STiH4xx SoCs. So we cannot adopt the same glue for all these
> SoCs.
> Moreover, GiGa on STiD127 didn't work and, for all the SoCs, the RGMII
> couldn't run when the speed was 10Mbps (because the clock was not properly
> managed).
> Note that the phy clock needs to be provided by the platform as well as
> documented in the related binding file (updated as consequence).
>
> The old code supported too many configurations never adopted and validated.
> This made the code very complex to maintain and debug in case of issues.
>
> The patch simplifies all the configurations as commented in the tables
> inside the file and obviously it has been tested on all the boards
> based on the SoCs mentioned.
>
> With this patch, the dwmac-sti is also ready to support new configurations that
> will be available on next SoC generations.
Series applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists