lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 14 Oct 2014 17:03:11 -0400 (EDT)
From:	David Miller <>
Subject: Re: [Patch net] rds: avoid calling sock_kfree_s() on allocation

From: Cong Wang <>
Date: Tue, 14 Oct 2014 12:35:08 -0700

> From: Cong Wang <>
> It is okay to free a NULL pointer but not okay to mischarge the socket optmem
> accounting. Compile test only.
> Reported-by:
> Cc: Chien Yen <>
> Cc: Stephen Hemminger <>
> Signed-off-by: Cong Wang <>
> Signed-off-by: Cong Wang <>

Applied, and I'm going to add the following bug check to the tree too.

[PATCH] net: Trap attempts to call sock_kfree_s() with a NULL pointer.

Unlike normal kfree() it is never right to call sock_kfree_s() with
a NULL pointer, because sock_kfree_s() also has the side effect of
discharging the memory from the sockets quota.

Signed-off-by: David S. Miller <>
 net/core/sock.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/core/sock.c b/net/core/sock.c
index b4f3ea2..15e0c67 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -1718,6 +1718,8 @@ EXPORT_SYMBOL(sock_kmalloc);
 void sock_kfree_s(struct sock *sk, void *mem, int size)
+	if (WARN_ON_ONCE(!mem))
+		return;
 	atomic_sub(size, &sk->sk_omem_alloc);

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists