netdev - Re: something is wrong in commit 971f10eca1 - tcp: better TCP_SKB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <543D2435.8090002@winsoft.pl>
Date:	Tue, 14 Oct 2014 15:25:09 +0200
From:	Krzysztof Kolasa <kkolasa@...soft.pl>
To:	Cong Wang <cwang@...pensource.com>,
	Eric Dumazet <eric.dumazet@...il.com>
CC:	netdev <netdev@...r.kernel.org>, edumazet@...il.com,
	David Miller <davem@...emloft.net>
Subject: Re: something is wrong in commit 971f10eca1 - tcp: better TCP_SKB_CB
 layout to reduce cache line misses

W dniu 14.10.2014 o 02:09, Cong Wang pisze:
> On Mon, Oct 13, 2014 at 4:59 PM, Cong Wang <cwang@...pensource.com> wrote:
>> Probably not related with this bug, but with regarding to the
>> offending commit, what's the point of the memmove() in tcp_v4_rcv()
>> since ip_rcv() already clears IPCB()?
> Oh, ip options are actually saved in ip_rcv_finish()... Hmm, looks scary
> to play with variable-length array with memmove()....
>
On my other old laptop with 32bit kernel next and graphics card Intel 
945GM just after the revert commit working OK,
before, after login to gnome shell in some seconds decorations disappear

32 bit Ubuntu 12.04.5 LTS, gnome shell, kernel source next 14-10-2014

Can anyone confirm this ?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html