netdev - Re: [PATCH v2 1/1] net: fec: Fix sparse warnings with different lock contexts for basic block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141014.125356.683543714454912616.davem@davemloft.net>
Date:	Tue, 14 Oct 2014 12:53:56 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	b38611@...escale.com
Cc:	netdev@...r.kernel.org, festevam@...il.com, sparse@...isli.org,
	B20596@...escale.com
Subject: Re: [PATCH v2 1/1] net: fec: Fix sparse warnings with different
 lock contexts for basic block

From: Fugang Duan <b38611@...escale.com>
Date: Mon, 13 Oct 2014 10:53:48 +0800

> reproduce:
> make  ARCH=arm C=1 2>fec.txt drivers/net/ethernet/freescale/fec_main.o
> cat fec.txt
> 
> sparse warnings:
> drivers/net/ethernet/freescale/fec_main.c:2916:12: warning: context imbalance
> in 'fec_set_features' - different lock contexts for basic block
> 
> Christopher Li suggest to change as below:
> 	if (need_lock) {
> 		lock();
> 		do_something_real();
> 		unlock();
> 	} else {
> 		do_something_real();
> 	}
> 
> Reported-by: Fabio Estevam <festevam@...il.com>
> Suggested-by: Christopher Li <sparse@...isli.org>
> Signed-off-by: Fugang Duan <B38611@...escale.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html