netdev - Re: [patch net repost] ipv4: fix nexthop attlen check in fib_nh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 14 Oct 2014 15:33:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jiri@...nulli.us
Cc:	netdev@...r.kernel.org, kuznet@....inr.ac.ru, jmorris@...ei.org,
	yoshfuji@...ux-ipv6.org, kaber@...sh.net, edumazet@...gle.com,
	tgraf@...g.ch
Subject: Re: [patch net repost] ipv4: fix nexthop attlen check in
 fib_nh_match

From: Jiri Pirko <jiri@...nulli.us>
Date: Mon, 13 Oct 2014 16:34:10 +0200

> fib_nh_match does not match nexthops correctly. Example:
> 
> ip route add 172.16.10/24 nexthop via 192.168.122.12 dev eth0 \
>                           nexthop via 192.168.122.13 dev eth0
> ip route del 172.16.10/24 nexthop via 192.168.122.14 dev eth0 \
>                           nexthop via 192.168.122.15 dev eth0
> 
> Del command is successful and route is removed. After this patch
> applied, the route is correctly matched and result is:
> RTNETLINK answers: No such process
> 
> Please consider this for stable trees as well.
> 
> Fixes: 4e902c57417c4 ("[IPv4]: FIB configuration using struct fib_config")
> Signed-off-by: Jiri Pirko <jiri@...nulli.us>
> Acked-by: Eric Dumazet <edumazet@...gle.com>
> ---
> reposted with example (it was missing for some reason in the original post)

Applied and queued up for -stable, thanks Jiri!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html