netdev - Re: [PATCHv3 RFC net-next 2/4] sunvnet: Use RCU to synchronize port usage with vnet_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <543EA696.3010607@oracle.com>
Date:	Wed, 15 Oct 2014 12:53:42 -0400
From:	David L Stevens <david.stevens@...cle.com>
To:	Sowmini Varadhan <sowmini.varadhan@...cle.com>,
	davem@...emloft.net, bob.picco@...cle.com, dwight.engen@...cle.com
CC:	netdev@...r.kernel.org
Subject: Re: [PATCHv3 RFC net-next 2/4] sunvnet: Use RCU to synchronize port
 usage with vnet_port_remove()



On 10/15/2014 12:43 PM, Sowmini Varadhan wrote:

>  
> @@ -1000,6 +1003,7 @@ static int vnet_start_xmit(struct sk_buff *skb, struct net_device *dev)
...
>  #if IS_ENABLED(CONFIG_IPV6)
> -		else if (skb->protocol == htons(ETH_P_IPV6))
> +		else if (skb->protocol == htons(ETH_P_IPV6)) {
> +			rcu_read_unlock();
>  			icmpv6_send(skb, ICMPV6_PKT_TOOBIG, 0, localmtu);
> +		}
>  #endif
>  		goto out_dropped;
>  	}

I don't think you want this one; "out_dropped" does this already:


>  
>  out_dropped:
...
>  		del_timer(&port->clean_timer);
> +	if (port)
> +		rcu_read_unlock();
> +	if (skb)
> +		dev_kfree_skb(skb);
> +	vnet_free_skbs(freeskbs);
>  	dev->stats.tx_dropped++;
>  	return NETDEV_TX_OK;
>  }


					+-DLS

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html