netdev - Re: [PATCHv3 RFC net-next 1/4] sunvnet: NAPIfy sunvnet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141015172204.GF11840@oracle.com>
Date:	Wed, 15 Oct 2014 13:22:04 -0400
From:	Sowmini Varadhan <sowmini.varadhan@...cle.com>
To:	David L Stevens <david.stevens@...cle.com>
Cc:	davem@...emloft.net, bob.picco@...cle.com, dwight.engen@...cle.com,
	raghuram.kothakota@...cle.com, netdev@...r.kernel.org
Subject: Re: [PATCHv3 RFC net-next 1/4] sunvnet: NAPIfy sunvnet

On (10/15/14 13:17), David L Stevens wrote:
> > -static void maybe_tx_wakeup(unsigned long param)
> > +static void maybe_tx_wakeup(struct vnet *vp)
> >  {
> > -	struct vnet *vp = (struct vnet *)param;
> >  	struct net_device *dev = vp->dev;
> >  
> >  	netif_tx_lock(dev);
> 
> Isn't this a function type conflict for tasklet_init()?

maybe_tx_wakeup is not a tasklet any more. That was one of the
big benefits of going NAPI, as David Miller pointed out- we
are already in NAPI context, so the original reason (deadlock
with dev_watchdog) does not exist any more.

I'm working on adding the rest of your comments about
removing comments and making an int into a bool.

--Sowmini

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html