netdev - Re: something is wrong in commit 971f10eca1 - tcp: better TCP_SKB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1413409354.17186.2.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 15 Oct 2014 14:42:34 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Cong Wang <cwang@...pensource.com>
Cc:	Krzysztof Kolasa <kkolasa@...soft.pl>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <edumazet@...il.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: something is wrong in commit 971f10eca1 - tcp: better
 TCP_SKB_CB layout to reduce cache line misses

On Wed, 2014-10-15 at 14:39 -0700, Eric Dumazet wrote:
> On Wed, 2014-10-15 at 13:36 -0700, Cong Wang wrote:
> > On Wed, Oct 15, 2014 at 3:35 AM, Krzysztof Kolasa <kkolasa@...soft.pl> wrote:
> > >
> > > one-line patch not resolve problem, fix created by Cong Wang resolves
> > > problem !!!
> > >
> > > tested on 64bit system and working OK
> > >
> > 
> > So my patch fixes your problem on 64bit but not on 32bit,
> > is this correct?
> > 
> > I will send out the patch. And as Eric said, the problem on 32bit
> > might be a different issue, we can definitely fix it separately.
> > 
> > Thanks for testing!
> 
> I think more fixes are needed.
> 
> This is most probably an IPv6 issue.
> 

Yes, ipv6 uses inet6_iif() a lot. We need to use a different accessor.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html