netdev - Re: [PATCH] gianfar: disable vlan tag insertion by default on 2.6.x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Oct 2014 18:22:24 +0800
From:	zhuyj <zyjzyj2000@...il.com>
To:	yzhu1 <Yanjun.Zhu@...driver.com>, Willy Tarreau <w@....eu>
CC:	sandeep.kumar@...escale.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Yue.Tao@...driver.com,
	guang.yang@...driver.com, joe@...ches.com, festevam@...il.com,
	richardcochran@...il.com, clarocq@...il.com,
	yongjun_wei@...ndmicro.com.cn, claudiu.manoil@...escale.com,
	roy.xu@...wei.com, sky.wangfeng@...wei.com,
	zhuyj <zyjzyj2000@...il.com>
Subject: Re: [PATCH] gianfar: disable vlan tag insertion by default on 2.6.x

On 10/15/2014 06:15 PM, yzhu1 wrote:
> On 10/15/2014 06:09 PM, Willy Tarreau wrote:
>> Hi Zhu,
>>
>> On Wed, Oct 15, 2014 at 06:00:33PM +0800, Zhu Yanjun wrote:
>>> In commit f43c75d4b6[gianfar: disable TX vlan based on kernel 2.6.x],
>>> gianfar nic disables TX vlan. But gianfar nic enables vlan tag
>>> insertion by default. This will lead to unusable connections on
>>> some configurations. Since vlan tag insertion is disabled by default
>>> and it is not enabled any longer, it is not necessary to disable it 
>>> again.
>>>
>>> Zhu Yanjun (1):
>>>    gianfar: disable vlan tag insertion by default
>>>
>>>   drivers/net/gianfar.c | 6 ------
>>>   1 file changed, 6 deletions(-)
>>>
>>> -- 
>>> 1.9.1
>> There's no patch in this e-mail. Since you sent another e-mail with 
>> almost
>> the same subject, I'm confused, it's unclear to me whether I only 
>> need to
>> apply the patch in the other one with this commit message or if it's 
>> just
>> that you accidently dropped the patch when sending this e-mail. Could 
>> you
>> please enlighten me ?
>>
>> Thanks,
>> Willy
>>
> Hi, Willy
>
> Sorry. Please apply the patch in the other one with this commit message.
>
> Thanks a lot.
> Zhu Yanjun
>
Hi, Willy

Sorry, it is my fault. Please apply this patch in the attachment.

Thanks a lot.
Zhu Yanjun


View attachment "0001-gianfar-disable-vlan-tag-insertion-by-default.patch" of type "text/x-patch" (1688 bytes)