netdev - Re: [PATCH] openvswitch: fix a use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEP_g=9dcPGNTFTL729yFFSUzyZ7OHQaVa9cJLGihqdoT+X66g@mail.gmail.com>
Date:	Thu, 16 Oct 2014 16:58:49 +0200
From:	Jesse Gross <jesse@...ira.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	roy.qing.li@...il.com, netdev <netdev@...r.kernel.org>,
	Andy Zhou <azhou@...ira.com>,
	Pravin B Shelar <pshelar@...ira.com>
Subject: Re: [PATCH] openvswitch: fix a use after free

On Thu, Oct 16, 2014 at 4:12 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Thu, 2014-10-16 at 17:01 +0800, roy.qing.li@...il.com wrote:
>>
>>               arp = (struct arp_eth_header *)skb_network_header(skb);
>>
>> -             if (arphdr_ok(skb) &&
>> +             if (arp_t &&
>>                   arp->ar_hrd == htons(ARPHRD_ETHER) &&
>>                   arp->ar_pro == htons(ETH_P_IP) &&
>>                   arp->ar_hln == ETH_ALEN &&
>
> Fixes: 0714812134d7d ("openvswitch: Eliminate memset() from flow_extract.")
>
> By doing this bug hunting, you also can CC bug author so that he knows
> what happened. Maybe he will avoid similar mistakes in the future.

Yes, this one is my fault. Thanks for tracking it down.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html