netdev - RE: [PATCH net] ipv6: introduce tcp_v6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1C9D8C89@AcuExch.aculab.com>
Date:	Fri, 17 Oct 2014 16:26:51 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Eric Dumazet' <eric.dumazet@...il.com>,
	David Miller <davem@...emloft.net>
CC:	netdev <netdev@...r.kernel.org>
Subject: RE: [PATCH net] ipv6: introduce tcp_v6_iif()

From: Eric Dumazet
> Commit 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache line
> misses") added a regression for SO_BINDTODEVICE on IPv6.
> 
> This is because we still use inet6_iif() which expects that IP6 control
> block is still at the beginning of skb->cb[]
> 
> This patch adds tcp_v6_iif() helper and uses it where necessary.
> 
> Because __inet6_lookup_skb() is used by TCP and DCCP, we add an iif
> parameter to it.
...
> diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
> index cf2e45ab2fa4..831495529b82 100644
> --- a/net/ipv6/tcp_ipv6.c
> +++ b/net/ipv6/tcp_ipv6.c
> @@ -424,6 +424,7 @@ static void tcp_v6_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
>  		if (sock_owned_by_user(sk))
>  			goto out;
> 
> +		/* Note : We use inet6_iif() here, not tcp_v6_iif() */
>  		req = inet6_csk_search_req(sk, &prev, th->dest, &hdr->daddr,
>  					   &hdr->saddr, inet6_iif(skb));
>  		if (!req)

That comment isn't particularly informative....

	David