netdev - Re: [PATCH v2] vxlan: remove the dead codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7O7Yyd2XMkMnv5b_TLFekPCRRtOGG7bHgHs2Qd+YRu3Hg@mail.gmail.com>
Date:	Fri, 17 Oct 2014 10:33:08 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	Li RongQing <roy.qing.li@...il.com>
Cc:	netdev <netdev@...r.kernel.org>,
	Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH v2] vxlan: remove the dead codes

On Thu, Oct 16, 2014 at 11:04 PM,  <roy.qing.li@...il.com> wrote:
> From: Li RongQing <roy.qing.li@...il.com>
>
> remove the dead codes, no user uses vxlan_salt
>
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>
> ---
>  drivers/net/vxlan.c |    4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 77ab844..855a81d 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -152,8 +152,6 @@ struct vxlan_dev {
>         struct hlist_head fdb_head[FDB_HASH_SIZE];
>  };
>
> -/* salt for hash table */
> -static u32 vxlan_salt __read_mostly;

Hmm, it has never been used since it was born. Maybe we should
really use for vxlan hash table?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html