lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 17 Oct 2014 13:40:24 -0700
From:	Pravin Shelar <>
To:	David Miller <>
Cc:	netdev <>,
	Daniele Di Proietto <>,
	Andy Zhou <>
Subject: Re: [PATCH net-next] openvswitch: Create right mask with disabled megaflows

On Fri, Oct 17, 2014 at 1:20 PM, David Miller <> wrote:
> From: Pravin B Shelar <>
> Date: Thu, 16 Oct 2014 21:55:45 -0700
>> If megaflows are disabled, the userspace does not send the netlink attribute
>> OVS_FLOW_ATTR_MASK, and the kernel must create an exact match mask.
>> sw_flow_mask_set() sets every bytes (in 'range') of the mask to 0xff, even the
>> bytes that represent padding for struct sw_flow, or the bytes that represent
>> fields that may not be set during ovs_flow_extract().
>> This is a problem, because when we extract a flow from a packet,
>> we do not memset() anymore the struct sw_flow to 0.
>> This commit gets rid of sw_flow_mask_set() and introduces mask_set_nlattr(),
>> which operates on the netlink attributes rather than on the mask key. Using
>> this approach we are sure that only the bytes that the user provided in the
>> flow are matched.
>> Also, if the parse_flow_mask_nlattrs() for the mask ENCAP attribute fails, we
>> now return with an error.
>> This bug is introduced by commit 0714812134d7dcadeb7ecfbfeb18788aa7e1eaac
>> ("openvswitch: Eliminate memset() from flow_extract").
>> Reported-by: Alex Wang <>
>> Signed-off-by: Daniele Di Proietto <>
>> Signed-off-by: Andy Zhou <>
>> Signed-off-by: Pravin B Shelar <>
> Why are you targetting a bug fix like this to net-next?
I meant it for net tree. Can you take this patch for net?

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists