netdev - Re: [PATCH net] ipv6: introduce tcp_v6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1413646207.27176.28.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Sat, 18 Oct 2014 08:30:07 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] ipv6: introduce tcp_v6_iif()

On Fri, 2014-10-17 at 23:48 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Fri, 17 Oct 2014 09:17:20 -0700
> 
> > From: Eric Dumazet <edumazet@...gle.com>
> > 
> > Commit 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache line
> > misses") added a regression for SO_BINDTODEVICE on IPv6.
> > 
> > This is because we still use inet6_iif() which expects that IP6 control
> > block is still at the beginning of skb->cb[]
> > 
> > This patch adds tcp_v6_iif() helper and uses it where necessary.
> > 
> > Because __inet6_lookup_skb() is used by TCP and DCCP, we add an iif
> > parameter to it.
> > 
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> > Fixes: 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache line misses")
> 
> Applied.

Oh well, I forgot IPV6 could be not present in .config

Will send a patch, sorry for this.

$ make M=net/ipv4
  CC      net/ipv4/route.o
In file included from net/ipv4/route.c:102:0:
include/net/tcp.h: In function ‘tcp_v6_iif’:
include/net/tcp.h:738:32: error: ‘union <anonymous>’ has no member named ‘h6’
  return TCP_SKB_CB(skb)->header.h6.iif;



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html