netdev - Re: [PATCH] ipv6: fix a potential use after free in ip6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1413647439.27176.35.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Sat, 18 Oct 2014 08:50:39 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: fix a potential use after free in ip6_offload.c

On Sat, 2014-10-18 at 17:27 +0800, roy.qing.li@...il.com wrote:
> From: Li RongQing <roy.qing.li@...il.com>
> 
> pskb_may_pull() maybe change skb->data and make opth pointer oboslete,
> so set the opth again
> 
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>
> ---
>  net/ipv6/ip6_offload.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c
> index 9034f76..91014d3 100644
> --- a/net/ipv6/ip6_offload.c
> +++ b/net/ipv6/ip6_offload.c
> @@ -46,6 +46,7 @@ static int ipv6_gso_pull_exthdrs(struct sk_buff *skb, int proto)
>  		if (unlikely(!pskb_may_pull(skb, len)))
>  			break;
>  
> +		opth = (void *)skb->data;
>  		proto = opth->nexthdr;
>  		__skb_pull(skb, len);
>  	}

Acked-by: Eric Dumazet <edumazet@...gle.com>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html