netdev - Re: [PATCH v2] Net: DSA: Fix checking for get_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 19 Oct 2014 12:46:51 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	andrew@...n.ch
Cc:	f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] Net: DSA: Fix checking for get_phy_flags function

From: Andrew Lunn <andrew@...n.ch>
Date: Sun, 19 Oct 2014 16:41:47 +0200

> The check for the presence or not of the optional switch function
> get_phy_flags() called the function, rather than checked to see if it
> is a NULL pointer. This causes a derefernce of a NULL pointer on all
> switch chips except the sf2, the only switch to implement this call.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> Fixes: 6819563e646a ("net: dsa: allow switch drivers to specify phy_device::dev_flags")
> Cc: Florian Fainelli <f.fainelli@...il.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html