[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1413751340-19621-1-git-send-email-fw@strlen.de>
Date: Sun, 19 Oct 2014 22:42:17 +0200
From: Florian Westphal <fw@...len.de>
To: netdev@...r.kernel.org
Cc: edumazet@...gle.com
Subject: [PATCH 0/3] net: minor gso encapsulation fixes
The following series fixes a minor bug in the gro segmentation handlers
when handling encapsulation offloads.
Theoretically this could cause kernel panic when the stack tries
to software-segment such a GRE offload packet, but it looks like there
is only one affected call site (tbf scheduler) and it handles NULL
return value.
I've included a followup patch to add IS_ERR_OR_NULL checks to all
the various skb_gso_segment call sites.
While looking into this, I also found that size computation of the individual
segments is incorrect as we do not consider skb->encapsulation.
core/skbuff.c | 13 ++++++++++---
ipv4/af_inet.c | 2 +-
ipv4/gre_offload.c | 2 +-
ipv4/ip_output.c | 2 +-
ipv4/udp_offload.c | 2 +-
ipv6/ip6_offload.c | 2 +-
mpls/mpls_gso.c | 2 +-
netfilter/nfnetlink_queue_core.c | 2 +-
openvswitch/datapath.c | 2 +-
xfrm/xfrm_output.c | 2 +-
10 files changed, 19 insertions(+), 12 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists