netdev - Re: [PATCH] Net: DSA: Fix checking for get_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 18 Oct 2014 20:08:50 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Andrew Lunn <andrew@...n.ch>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] Net: DSA: Fix checking for get_phy_flags function

2014-10-18 17:13 GMT-07:00 Andrew Lunn <andrew@...n.ch>:
> The check for the presence or not of the optional switch function
> get_phy_flags() called the function, rather than checking to see if it
> is a NULL pointer. This causes a derefernce of a NULL pointer on all
> switch chips except the sf2, the only switch to implement this call.

Sorry about this one, good catch.

>
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> Fixes: 6819563e646a "net: dsa=: allow switch drivers to ...

Could you resubmit without stripping the "Fixes" subject?

> Cc: Florian Fainelli <f.fainelli@...il.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

> ---
>  net/dsa/slave.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/dsa/slave.c b/net/dsa/slave.c
> index 9d3b12b4e03c..fbcba4bc4e08 100644
> --- a/net/dsa/slave.c
> +++ b/net/dsa/slave.c
> @@ -596,7 +596,7 @@ dsa_slave_create(struct dsa_switch *ds, struct device *parent,
>         netif_carrier_off(slave_dev);
>
>         if (p->phy != NULL) {
> -               if (ds->drv->get_phy_flags(ds, port))
> +               if (ds->drv->get_phy_flags)
>                         p->phy->dev_flags |= ds->drv->get_phy_flags(ds, port);
>
>                 phy_attach(slave_dev, dev_name(&p->phy->dev),
> --
> 2.1.1
>



-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html