lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Oct 2014 09:05:04 +0200 From: Florian Westphal <fw@...len.de> To: David Miller <davem@...emloft.net> Cc: fw@...len.de, netdev@...r.kernel.org, edumazet@...gle.com Subject: Re: [PATCH 2/4] net: make skb_gso_segment error handling more robust David Miller <davem@...emloft.net> wrote: > From: Florian Westphal <fw@...len.de> > Date: Sun, 19 Oct 2014 22:42:19 +0200 > > > skb_gso_segment has three possible return values: > > 1. a pointer to the first segmented skb > > 2. an errno value (IS_ERR()) > > 3. NULL. This can happen when GSO is used for header verification. > > > > However, several callers currently test IS_ERR instead of IS_ERR_OR_NULL > > and would oops when NULL is returned. > > > > Note that these call sites should never actually see such a NULL return > > value; all callers mask out the GSO bits in the feature argument. > > > > However, in the past, there have been issues with some protocol handlers > > erronously not respecting the specified feature mask in some cases. > > > > Signed-off-by: Florian Westphal <fw@...len.de> > > I don't think it makes sense to return PTR_ERR(p) when > p is NULL. Good point. Will respin. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists