netdev - Re: [PATCH net] ax88179_178a: fix bonding failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141020.005526.1789570582328212500.davem@davemloft.net>
Date:	Mon, 20 Oct 2014 00:55:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	imorgan@...mordial.ca
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] ax88179_178a: fix bonding failure

From: Ian Morgan <imorgan@...mordial.ca>
Date: Sun, 19 Oct 2014 08:05:13 -0400 (EDT)

> The following patch fixes a bug which causes the ax88179_178a driver to be
> incapable of being added to a bond.
> 
> When I brought up the issue with the bonding maintainers, they indicated
> that the real problem was with the NIC driver which must return zero for
> success (of setting the MAC address). I see that several other NIC drivers
> follow that pattern by either simply always returing zero, or by passing
> through a negative (error) result while rewriting any positive return code
> to zero. With that same philisophy applied to the ax88179_178a driver, it
> allows it to work correctly with the bonding driver.
> 
> I believe this is suitable for queuing in -stable, as it's a small, simple,
> and obvious fix that corrects a defect with no other known workaround.
> 
> This patch is against vanilla 3.17(.0).
> 
> Signed-off-by: Ian Morgan <imorgan@...mordial.ca>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html