netdev - Re: [PATCH net] tipc: fix lockdep warning when intra-node messages are delivered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141021.153025.246696199217285626.davem@davemloft.net>
Date:	Tue, 21 Oct 2014 15:30:25 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ying.xue@...driver.com
Cc:	jon.maloy@...csson.com, erik.hugne@...csson.com,
	netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net] tipc: fix lockdep warning when intra-node messages
 are delivered

From: Ying Xue <ying.xue@...driver.com>
Date: Mon, 20 Oct 2014 14:46:35 +0800

> When running tipcTC&tipcTS test suite, below lockdep unsafe locking
> scenario is reported:
 ...
> When intra-node messages are delivered from one process to another
> process, tipc_link_xmit() doesn't disable BH before it directly calls
> tipc_sk_rcv() on process context to forward messages to destination
> socket. Meanwhile, if messages delivered by remote node arrive at the
> node and their destinations are also the same socket, tipc_sk_rcv()
> running on process context might be preempted by tipc_sk_rcv() running
> BH context. As a result, the latter cannot obtain the socket lock as
> the lock was obtained by the former, however, the former has no chance
> to be run as the latter is owning the CPU now, so headlock happens. To
> avoid it, BH should be always disabled in tipc_sk_rcv().
> 
> Signed-off-by: Ying Xue <ying.xue@...driver.com>
> Reviewed-by: Jon Maloy <jon.maloy@...csson.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html