netdev - Re: [PATCH] net: fec: ptp: fix NULL pointer dereference if ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 22 Oct 2014 17:48:41 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	p.zabel@...gutronix.de
Cc:	b45643@...escale.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: fec: ptp: fix NULL pointer dereference if
 ptp_clock is not set

From: Philipp Zabel <p.zabel@...gutronix.de>
Date: Wed, 22 Oct 2014 16:34:35 +0200

> Since commit 278d24047891 (net: fec: ptp: Enable PPS output based on ptp clock)
> fec_enet_interrupt calls fec_ptp_check_pps_event unconditionally, which calls
> into ptp_clock_event. If fep->ptp_clock is NULL, ptp_clock_event tries to
> dereference the NULL pointer.
> Since on i.MX53 fep->bufdesc_ex is not set, fec_ptp_init is never called,
> and fep->ptp_clock is NULL, which reliably causes a kernel panic.
> 
> This patch adds a check for fep->ptp_clock == NULL in fec_enet_interrupt.
> 
> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html