lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 22 Oct 2014 15:43:50 +0400 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Varka Bhadram <varkabhadram@...il.com>, netdev@...r.kernel.org CC: Varka Bhadram <varkab@...c.in> Subject: Re: [PATCH net-next 1/6] ethernet: wiznet: remove unnecessary check Hello. On 10/22/2014 8:16 AM, Varka Bhadram wrote: > devm_ioremap_resource checks platform_get_resource() return value. > We can remove the duplicate check here. > Signed-off-by: Varka Bhadram <varkab@...c.in> > --- > drivers/net/ethernet/wiznet/w5100.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > diff --git a/drivers/net/ethernet/wiznet/w5100.c b/drivers/net/ethernet/wiznet/w5100.c > index 0f56b1c..bf195e3 100644 > --- a/drivers/net/ethernet/wiznet/w5100.c > +++ b/drivers/net/ethernet/wiznet/w5100.c > @@ -638,8 +638,7 @@ static int w5100_hw_probe(struct platform_device *pdev) > } > > mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!mem) > - return -ENXIO; > + > mem_size = resource_size(mem); This would cause a NULL dereference on resource_size() call if 'mem' is NULL. You can't remove the NULL check because of that. > > priv->base = devm_ioremap_resource(&pdev->dev, mem); > WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists