netdev - Re: [PATCH 1/2] xfrm: fix a potential use after free in xfrm4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141021.214252.1991608537444325198.davem@davemloft.net>
Date:	Tue, 21 Oct 2014 21:42:52 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org, steffen.klassert@...unet.com
Subject: Re: [PATCH 1/2] xfrm: fix a potential use after free in
 xfrm4_policy.c

From: roy.qing.li@...il.com
Date: Mon, 20 Oct 2014 16:49:13 +0800

> From: Li RongQing <roy.qing.li@...il.com>
> 
> pskb_may_pull() maybe change skb->data and make xprth pointer oboslete,
> so recompute the xprth
> 
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>

Please don't use macros that hide uses of local variables.

That is almost as bad as hiding control flow inside of
a macro.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html