netdev - Re: [PATCH net] tcp: md5: percpu tcp_md5sig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1414092849.20845.21.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 23 Oct 2014 12:34:09 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jonathan Toppins <jtoppins@...ulusnetworks.com>
Cc:	David Miller <davem@...emloft.net>,
	David Ahern <dsahern@...il.com>,
	Crestez Dan Leonard <cdleonard@...il.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH net] tcp: md5: percpu tcp_md5sig_pool must not span pages

On Thu, 2014-10-23 at 09:33 -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> percpu tcp_md5sig_pool contains memory blobs that ultimately
> go through sg_set_buf().
> 
> -> sg_set_page(sg, virt_to_page(buf), buflen, offset_in_page(buf));
> 
> This requires that whole area is in a physically contiguous portion
> of memory.
> 
> Given that alloc_percpu() can use vmalloc() areas, we need to make sure
> tcp_md5sig_pool is allocated from a single page.
> 
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Fixes: 765cf9976e93 ("tcp: md5: remove one indirection level in tcp_md5sig_pool")
> Reported-by: Crestez Dan Leonard <cdleonard@...il.com>
> ---

Self Nack, we definitely need to avoid vmalloc() in the first place.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html