lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 22 Oct 2014 22:21:29 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Florian Fainelli <f.fainelli@...il.com> CC: netdev <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 11/14] net: dsa: Add support for reading switch registers with ethtool On 10/22/2014 09:40 PM, Florian Fainelli wrote: > 2014-10-22 21:03 GMT-07:00 Guenter Roeck <linux@...ck-us.net>: >> Add support for reading switch registers with 'ethtool -d'. >> >> Signed-off-by: Guenter Roeck <linux@...ck-us.net> >> --- > > [snip] > >> >> +static int dsa_slave_get_regs_len(struct net_device *dev) >> +{ >> + struct dsa_slave_priv *p = netdev_priv(dev); >> + struct dsa_switch *ds = p->parent; >> + >> + if (ds->drv->get_regs_len != NULL) >> + return ds->drv->get_regs_len(ds, p->port); > > Most of the checks in this file are just: > > if (ds->drv->callback) > return ds->drv->callback(...) > Hi Florian, To be fair, that wasn't the case when I wrote the code ;-). No problem, I'll do the same. >> + >> + return -EOPNOTSUPP; >> +} >> + >> +static void >> +dsa_slave_get_regs(struct net_device *dev, struct ethtool_regs *regs, void *_p) >> +{ >> + struct dsa_slave_priv *p = netdev_priv(dev); >> + struct dsa_switch *ds = p->parent; >> + >> + ds->drv->get_regs(ds, p->port, regs, _p); > > We need to check that the driver does implement this callback here as well. > Obviously, and embarrassing ;-). Thanks a lot for the review! Guenter -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists