netdev - Re: [net-next 0/9][pull request] Intel Wired LAN Driver Updates 2014-10-23

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141024.164327.535125094046571848.davem@davemloft.net>
Date:	Fri, 24 Oct 2014 16:43:27 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
	jogreene@...hat.com
Subject: Re: [net-next 0/9][pull request] Intel Wired LAN Driver Updates
 2014-10-23

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu, 23 Oct 2014 21:09:57 -0700

> This series contains updates to i40e and i40evf.
> 
> Jesse modifies the i40e driver to only notify the firmware on link up/down
> and qualified module events.  Also simplified the job of managing link
> state by using the admin queue receive event for link events as a signal
> to tell the driver to update link state.
> 
> Jeff (me) cleans up the inconsistent use of tabs for indentation in the admin
> queue command header file.
> 
> Neerav converts the use of udelay() to usleep_range().
> 
> Anjali fixes a bug where receive would stop after some stress by adding
> a sleep and restart as well as moving the setting of flow control because
> it should be done at a PF level and not a VSI level.
> 
> Mitch adds code to handle link events when updating the PF switch, which
> allows link information to be properly provided to VFS in all cases.
> 
> Catherine adds driver support for 10GBaseT and bumps driver version.

I've pulled, but I absolutely don't like that change that moved the
variables out of the loop.

Putting variables in the inner-most scope of their use is always the
best choice because:

1) Auditing is easier, because you are constraining the scope in
   which you have to check if the variable is setup properly
   before it is used.

2) You are helping the compiler out, because you have done the
   majority of solving the graph coloring problem for it and the
   compiler therefore has less work to do.

Please don't make changes like this in the future, and instead do the
opposite, by moving more variable declarations into their innermost
possible scope.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html