netdev - Re: [PATCH v2 1/2] net: dsa: Error out on tagging protocol mismatches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <544AD5D0.4070908@gmail.com>
Date:	Fri, 24 Oct 2014 15:42:24 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Andrew Lunn <andrew@...n.ch>, davem@...emloft.net
CC:	netdev@...r.kernel.org,
	Alexander Duyck <alexander.h.duyck@...hat.com>
Subject: Re: [PATCH v2 1/2] net: dsa: Error out on tagging protocol mismatches

On 10/24/2014 02:44 PM, Andrew Lunn wrote:
> If there is a mismatch between enabled tagging protocols and the
> protocol the switch supports, error out, rather than continue with a
> situation which is unlikely to work.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

> cc: alexander.h.duyck@...el.com
> ---
> 
> v2: Handle the use case of DSA_TAG_PROTO_NONE
> 
>  net/dsa/dsa.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
> index 22f34cf4cb27..6317b41c99b0 100644
> --- a/net/dsa/dsa.c
> +++ b/net/dsa/dsa.c
> @@ -174,8 +174,11 @@ dsa_switch_setup(struct dsa_switch_tree *dst, int index,
>  			dst->rcv = brcm_netdev_ops.rcv;
>  			break;
>  #endif
> -		default:
> +		case DSA_TAG_PROTO_NONE:
>  			break;
> +		default:
> +			ret = -ENOPROTOOPT;
> +			goto out;
>  		}
>  
>  		dst->tag_protocol = drv->tag_protocol;
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html