lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 Oct 2014 11:13:56 -0700 From: Cong Wang <cwang@...pensource.com> To: John Fastabend <john.fastabend@...il.com> Cc: wang.bo116@....com.cn, David Miller <davem@...emloft.net>, Patrick McHardy <kaber@...sh.net>, netdev <netdev@...r.kernel.org>, cui.yunfeng@....com.cn Subject: Re: [PATCH net] net/sched: Fix use of wild pointer in mq_destroy() when qdisc_alloc fail On Fri, Oct 24, 2014 at 10:49 AM, John Fastabend <john.fastabend@...il.com> wrote: > > Patch looks fine, another way to fix this would be drop the > mq_destroy() call in the error path. I'm not convinced one > is any better than the other but maybe some other folks have > opinions, it seems a bit wrong to call mq_destroy twice so in > that sense it may be a bit nicer to drop the mq_destroy(). Dropping mq_destroy() in error path is indeed better, because upper layer does cleanup intentionally. Look at what other qdisc's do. :) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists