netdev - Re: [PATCH net-next v2 5/6] ethernet: renesas: remove unnecessary check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5449B62F.4020002@gmail.com>
Date:	Fri, 24 Oct 2014 07:45:11 +0530
From:	Varka Bhadram <varkabhadram@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	netdev@...r.kernel.org
CC:	davem@...emloft.net, Varka Bhadram <varkab@...c.in>
Subject: Re: [PATCH net-next v2 5/6] ethernet: renesas: remove unnecessary
 check


On Thursday 23 October 2014 05:59 PM, Sergei Shtylyov wrote:
> On 10/23/2014 5:58 AM, Varka Bhadram wrote:
>
>> devm_ioremap_resource checks platform_get_resource() return value.
>> We can remove the duplicate check here.
>
>> Signed-off-by: Varka Bhadram <varkab@...c.in>
>> ---
>>   drivers/net/ethernet/renesas/sh_eth.c |    9 +++------
>>   1 file changed, 3 insertions(+), 6 deletions(-)
>
>> diff --git a/drivers/net/ethernet/renesas/sh_eth.c 
>> b/drivers/net/ethernet/renesas/sh_eth.c
>> index 60e9c2c..ffb49f3 100644
>> --- a/drivers/net/ethernet/renesas/sh_eth.c
>> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> [...]
>> @@ -2781,8 +2777,6 @@ static int sh_eth_drv_probe(struct 
>> platform_device *pdev)
>>       pm_runtime_enable(&pdev->dev);
>>       pm_runtime_get_sync(&pdev->dev);
>>
>> -    /* The sh Ether-specific entries in the device structure. */
>> -    ndev->base_addr = res->start;
>>       devno = pdev->id;
>>       if (devno < 0)
>>           devno = 0;
>> @@ -2806,6 +2800,9 @@ static int sh_eth_drv_probe(struct 
>> platform_device *pdev)
>>           goto out_release;
>>       }
>>
>> +    /* The sh Ether-specific entries in the device structure. */
>
>    No need to move the comment, at least not there.
>
>> +    ndev->base_addr = res->start;
>> +
>>       spin_lock_init(&mdp->lock);
>>       mdp->pdev = pdev;
>
> WBR, Sergei
>
thanks for the review. In v3 i will address these issues.

-- 
Thanks and Regards,
Varka Bhadram.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html