netdev - Re: [PATCH net] macvlan: fix a race on port dismantle and possible skb leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141025.162421.21065553248053378.davem@davemloft.net>
Date:	Sat, 25 Oct 2014 16:24:21 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] macvlan: fix a race on port dismantle and possible
 skb leaks

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Thu, 23 Oct 2014 11:28:58 +0800

> On Wed, Oct 22, 2014 at 07:43:46PM -0700, Eric Dumazet wrote:
>> From: Eric Dumazet <edumazet@...gle.com>
>> 
>> We need to cancel the work queue after rcu grace period,
>> otherwise it can be rescheduled by incoming packets.
>> 
>> We need to purge queue if some skbs are still in it.
>> 
>> We can use __skb_queue_head_init() variant in
>> macvlan_process_broadcast()
>> 
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>> Fixes: 412ca1550cbec ("macvlan: Move broadcasts into a work queue")
>> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> 
> Good catch! Your fix looks good to me.

Applied and queued up for -stable, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html