lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <544F9ABC.4010306@roeck-us.net> Date: Tue, 28 Oct 2014 06:31:40 -0700 From: Guenter Roeck <linux@...ck-us.net> To: netdev@...r.kernel.org CC: "David S. Miller" <davem@...emloft.net>, Florian Fainelli <f.fainelli@...il.com>, Andrew Lunn <andrew@...n.ch>, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 09/15] net: dsa: Add support for switch EEPROM access On 10/26/2014 09:52 AM, Guenter Roeck wrote: > On some chips it is possible to access the switch eeprom. > Add infrastructure support for it. > > Signed-off-by: Guenter Roeck <linux@...ck-us.net> > --- [ ... ] > @@ -603,6 +604,9 @@ static int dsa_of_probe(struct platform_device *pdev) > if (pd->nr_chips > DSA_MAX_SWITCHES) > pd->nr_chips = DSA_MAX_SWITCHES; > > + if (!of_property_read_u32(np, "eeprom-length", &eeprom_length)) > + pd->eeprom_length = eeprom_length; This is buggy; please don't apply. Variable is named eeprom_len, and it is per switch. Lesson to self: When writing devicetree code, compile it with devicetree enabled. Guenter -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists