lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 28 Oct 2014 10:43:12 -0400
From:	Steven Rostedt <>
To:	Joe Perches <>
Cc:	Al Viro <>, Petr Mladek <>,
	Andrew Morton <>,
	Linus Torvalds <>,
	Jiri Kosina <>,
	Thomas Gleixner <>,
	Jeff Layton <>,
	"J. Bruce Fields" <>,,,,
Subject: Re: [PATCH 5/7] fs: Convert show_fdinfo functions to void

On Tue, 28 Oct 2014 07:31:32 -0700
Joe Perches <> wrote:

> > I wouldn't change logic on this. There's no reason to call this
> > function if it isn't doing anything.
> > 
> > I'll change this to just do the update and not change logic like this.
> Fewer #ifdefs

And there's other ways to fix it (like using an #else), but that is
off-topic to the current change set. In other words, that change should
be separate, as I don't want discussions on what's the best use of
#ifdefs distracting from getting in the "void seq_printf()" changes.

-- Steve

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists