lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 28 Oct 2014 10:43:12 -0400 From: Steven Rostedt <rostedt@...dmis.org> To: Joe Perches <joe@...ches.com> Cc: Al Viro <viro@...IV.linux.org.uk>, Petr Mladek <pmladek@...e.cz>, Andrew Morton <akpm@...ux-foundation.org>, Linus Torvalds <torvalds@...ux-foundation.org>, Jiri Kosina <jkosina@...e.cz>, Thomas Gleixner <tglx@...utronix.de>, Jeff Layton <jlayton@...chiereds.net>, "J. Bruce Fields" <bfields@...ldses.org>, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, linux-fsdevel@...r.kernel.org Subject: Re: [PATCH 5/7] fs: Convert show_fdinfo functions to void On Tue, 28 Oct 2014 07:31:32 -0700 Joe Perches <joe@...ches.com> wrote: > > I wouldn't change logic on this. There's no reason to call this > > function if it isn't doing anything. > > > > I'll change this to just do the update and not change logic like this. > > Fewer #ifdefs > And there's other ways to fix it (like using an #else), but that is off-topic to the current change set. In other words, that change should be separate, as I don't want discussions on what's the best use of #ifdefs distracting from getting in the "void seq_printf()" changes. -- Steve -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists