lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 28 Oct 2014 23:43:44 -0200 From: Murilo Opsfelder Araujo <mopsfelder@...il.com> To: Larry Finger <Larry.Finger@...inger.net>, linville@...driver.com CC: linux-wireless@...r.kernel.org, troy_tan@...lsil.com.cn, netdev@...r.kernel.org, Mike Galbraith <umgwanakikbuti@...il.com>, Thadeu Cascardo <cascardo@...cardo.eti.br> Subject: Re: [PATCH V3.18] rtlwifi: Add check for get_btc_status callback On 10/23/2014 02:27 PM, Larry Finger wrote: > Drivers that do not use the get_btc_status() callback may not define a > dummy routine. The caller needs to check before making the call. > > Signed-off-by: Larry Finger <Larry.Finger@...inger.net> > Cc: Murilo Opsfelder Araujo <mopsfelder@...il.com> > Cc: Mike Galbraith <umgwanakikbuti@...il.com> > Cc: Thadeu Cascardo <cascardo@...cardo.eti.br> > --- > > John, > > This missing statement is causing kernel crashes for several of the drivers. > This patch should be applied ASAP. > > Larry > --- > > drivers/net/wireless/rtlwifi/pci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c > index 667aba8..25daa87 100644 > --- a/drivers/net/wireless/rtlwifi/pci.c > +++ b/drivers/net/wireless/rtlwifi/pci.c > @@ -1796,7 +1796,8 @@ static int rtl_pci_start(struct ieee80211_hw *hw) > rtl_pci_reset_trx_ring(hw); > > rtlpci->driver_is_goingto_unload = false; > - if (rtlpriv->cfg->ops->get_btc_status()) { > + if (rtlpriv->cfg->ops->get_btc_status && > + rtlpriv->cfg->ops->get_btc_status()) { > rtlpriv->btcoexist.btc_ops->btc_init_variables(rtlpriv); > rtlpriv->btcoexist.btc_ops->btc_init_hal_vars(rtlpriv); > } > Hi, Larry & everyone. This patch didn't solve and next-20141028 is still crashing on my laptop with rtl8192se device: http://opsfelder.com/~murilo/lkml/next-20141028_crashing.jpg -- Murilo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists