lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Oct 2014 18:16:18 +0200 From: Emmanuel Grumbach <egrumbach@...il.com> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: Johannes Berg <johannes.berg@...el.com>, Emmanuel Grumbach <emmanuel.grumbach@...el.com>, Intel Linux Wireless <ilw@...ux.intel.com>, "John W. Linville" <linville@...driver.com>, Paul Gortmaker <paul.gortmaker@...driver.com>, Larry Finger <Larry.Finger@...inger.net>, linux-wireless <linux-wireless@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: Re: [patch] iwlwifi: cleanup a mask shift in iwlagn_bt_traffic_is_sco() On Wed, Oct 29, 2014 at 6:08 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote: > The shift operation is higher precedence so the code is wrong and it > sets of a static checker warning. But it doesn't affect real life > because BT_UART_MSG_FRAME3SCOESCO_POS is zero so the shift is a no-op. > > I have re-written it in normal style and with parenthesis as a cleanup > and to silence the static checker warning. > > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> > In my tree already - I got it from Joe. https://git.kernel.org/cgit/linux/kernel/git/iwlwifi/iwlwifi-next.git/commit/?id=50f6635afe565a0e1c5ab78f040294fe1dc41de0 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists